Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventsource dependency too old: 0.1.6 #407

Closed
christophercr opened this issue Sep 21, 2017 · 3 comments
Closed

eventsource dependency too old: 0.1.6 #407

christophercr opened this issue Sep 21, 2017 · 3 comments

Comments

@christophercr
Copy link

christophercr commented Sep 21, 2017

Hi, I just noticed that this library (used by webpack-dev-server btw) has a dependency to eventsource with a very old version: 0.1.6 (released in Feb 2015!).

I'm wondering why hasn't this been upgraded to a more recent version or even the latest one. It seems that there has been a lot of bugs/issues fixed since version 0.1.6 ;)

I noticed this since I'm implementing Server Sent Events in my app and I spotted two deps of the eventsource library in my package-lock.json. I use the latest version but I see that webpack-dev-server=>sockjs-client uses a very old one.

I thought this could be interesting for you...

@brycekahle
Copy link
Contributor

@christophercr I was waiting for EventSource/eventsource#60 to be fixed. It is also work to ensure the changes they made do not break SockJS (again).

@christophercr
Copy link
Author

Oh I see, well it seems it is solved now :)

@jkingdon
Copy link

jkingdon commented May 21, 2018

Is this upgrade now feasible? There is more reason to do it now that eventsource 0.1.6 depends (indirectly) on querystring 0.0.4 which has a security vulnerability ( fixed at unshiftio/querystringify#19 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants