Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sadly, enable cors behavior is incorrect #2

Open
dominictarr opened this issue Aug 29, 2021 · 1 comment
Open

sadly, enable cors behavior is incorrect #2

dominictarr opened this issue Aug 29, 2021 · 1 comment

Comments

@dominictarr
Copy link
Contributor

The enable cors functionality in this module is how I wish api-gateway worked -- it sets the header on the response, which is sent to the client, even if the lambda doesn't set it. however, this isn't actually how aws lambda works. When I was trying to make cors work with lambda it only worked when I explicitly set the cors headers in the lambda.

@Raynos
Copy link
Contributor

Raynos commented Aug 30, 2021

Right, this behavior should change to only handle the OPTIONS method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants