Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit put for non-object input #16

Open
Raynos opened this issue Feb 15, 2020 · 1 comment
Open

Audit put for non-object input #16

Raynos opened this issue Feb 15, 2020 · 1 comment
Labels
help wanted Extra attention is needed question Further information is requested tests An issue, task, or discussion related to tests

Comments

@Raynos
Copy link
Contributor

Raynos commented Feb 15, 2020

I don't know what put(hashKey, rangeKey, 'string') or boolean or number or null does currently.

If we treat the value to be inserted as DynamoDB JSON then we should throw a programmer error if it cannot be converted because a scalar was passed in instead.

@heapwolf
Copy link
Member

heapwolf commented Feb 15, 2020

there needs to be a test for that. The expected behavior of put(hashKey, rangeKey, null) should be trying to put a value of { NULL: true } (or something like that). In theory, all javascript types should be re-cast to dynamodb types

@jwerle jwerle added help wanted Extra attention is needed question Further information is requested tests An issue, task, or discussion related to tests labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested tests An issue, task, or discussion related to tests
Projects
None yet
Development

No branches or pull requests

3 participants