Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify table creation properties vs update TTL in docs #15

Open
Raynos opened this issue Feb 15, 2020 · 2 comments
Open

Clarify table creation properties vs update TTL in docs #15

Raynos opened this issue Feb 15, 2020 · 2 comments
Labels
docs An issue, task, or discussion related to documentation

Comments

@Raynos
Copy link
Contributor

Raynos commented Feb 15, 2020

When reading the README its not obvious to me that I cannot configure TTL in the CreateTable() method.

It would be useful to clarify in updateTTL() that

  • It should be done once after calling db.create(tableName, ...)
  • It cannot be done in create() because updating TTL is a seperate method, documenting that will reduce confusion.
@heapwolf
Copy link
Member

heapwolf commented Feb 15, 2020

it could be done in create, its just tricky to reason about how to send non related native sdk arguments.

@Raynos
Copy link
Contributor Author

Raynos commented Feb 15, 2020

I think the current implementaiton is good.

As a user of dynavolt i jsut didnt know that dynamodb has X metadata in Create and also 3 dangling meta that can only be applied with updateY()

@jwerle jwerle added the docs An issue, task, or discussion related to documentation label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue, task, or discussion related to documentation
Projects
None yet
Development

No branches or pull requests

3 participants