Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading release notice? #1112

Closed
vincentwoo opened this issue May 8, 2017 · 5 comments
Closed

Misleading release notice? #1112

vincentwoo opened this issue May 8, 2017 · 5 comments

Comments

@vincentwoo
Copy link

The release that went out 10 minutes ago says that it updates the engine-io client to 1.8.4, but the version that was actually released seems to peg to 3.1.0:

"engine.io-client": "~3.1.0"

"engine.io-client": "~3.1.0",

Was this intentional?

@darrachequesne
Copy link
Member

I think you are referring to 1.7.4 release note: https://github.com/socketio/socket.io-client/releases/tag/1.7.4.

engine.io-client was actually updated to 3.1.0 in 2.0.0. Or am I missing something?

@vincentwoo
Copy link
Author

I was confused, I think because the new release note hadn't made it. Can you speak to whether the 1.7x -> 2.x bump is breaking? Do I need to synchronously update the client and server? I couldn't find it in the docs but the semver bump is a bit scary.

@nuclearace
Copy link
Member

I think it bumped for the double-encoding of unicode change, correct?

@darrachequesne
Copy link
Member

I'll update the release note as soon as possible, but yes, the change @nuclearace is referring to is a breaking one (socketio/engine.io-parser#81).

@darrachequesne
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants