Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour placement should "stick" when scrolling vertically #31

Open
aloukianova opened this issue Dec 19, 2016 · 3 comments
Open

Tour placement should "stick" when scrolling vertically #31

aloukianova opened this issue Dec 19, 2016 · 3 comments

Comments

@aloukianova
Copy link

When there's a user tour attached to something in a scrollable pane, scrolling vertically will mess up the position of the tour.

Also, if there is a tour on an element that is out of view, the position of the tour is awkwardly stuck to the bottom, so when scrolling that element into view the tour will cover it up.

I would guess that the tour should scroll a hidden element into view and scroll together with it. This might be somewhat related to #28 .

Thanks

@conorhastings
Copy link
Contributor

I"m not sure I'm totally understanding? Can you provde more info/ an example?

@aloukianova
Copy link
Author

Sure. I'm not sure if these are two different issues:
I'm using a tour on a scrollable page, and when a user tour is active, scrolling on the page will mess up the alignment of the tour to the element it's attached to.
scroll-tour

The other problem I have is that one of the elements I'm showing a tour for is initially located out of sight near the end of the page. The tour will be positioned at the bottom of window, but never gets repositioned when the element is in sight and ends up covering the element itself when I scroll.
bottom-tour-scroll

@rudza
Copy link

rudza commented Jan 8, 2018

Here is an updated version of this package which fixes this issue: https://github.com/rudza/react-product-intro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants