Website: Nav bar optimization #1000

ssandino · 2025-01-04T19:21:55Z

Fixes Navi Issues:

long navi items fall on two lines (specially french)
medium screen Currency / Location / Lang div is reduced to one column
sub-navi items are also falling on two lines
the navi is jumping when initially loaded
spacing btw. navi items different
hover effect on Currency / Location / Lang was missing
nav items not really in the middle of screen
moved donation link in the navi up (it was initially planned to be at the bottom, but that placement didn’t make much sense)

Screenshot of issues:

Summary by CodeRabbit

Localization
- Updated French translation for "our-promise" navigation text
User Interface
- Refined navbar layout and responsiveness
- Adjusted navbar hover states and dropdown positioning
- Resized country flag icon
- Improved navigation link spacing
Navigation
- Reordered FAQ section in navigation menu

vercel · 2025-01-04T19:21:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
public	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 4, 2025 10:03pm

coderabbitai · 2025-01-04T19:22:01Z

📝 Walkthrough

Walkthrough

This pull request involves localization and UI modifications for the website. The changes include updating the French translation for the "our-promise" key in the localization file and making visual adjustments to the navbar component. The navbar's layout and styling have been refined, with specific changes to height, logo positioning, and dropdown behaviors.

Changes

File	Change Summary
`shared/locales/fr/website-common.json`	Updated "our-promise" translation from "Modèle à 100 %" to "Notre promesse"
`website/src/components/navbar/navbar-client.tsx`	- Reduced navbar height on hover from `h-96` to `h-60` - Modified logo section structure - Updated dropdown positioning and visibility - Adjusted flag image dimensions
`website/src/components/navbar/navbar.tsx`	Removed and re-added FAQ section entry in navigation array

Possibly related PRs

Web: Solving newsletter subscription issues #939: Adds French language support for newsletter subscription
Website: Transparency page (fixing bugs) #972: Addresses currency formatting and French localization file changes

Suggested labels

website

Suggested reviewers

andrashee
mkue
socialincome-dev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-04T19:26:01Z

Visit the preview URL for this PR (updated for commit 3a537b5):

https://si-admin-staging--pr1000-sandino-nav-wip-zn0re47a.web.app

_{(expires Sat, 11 Jan 2025 19:28:38 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676}

…v-wip # Conflicts: # website/src/components/navbar/navbar-client.tsx

ssandino · 2025-01-04T22:06:29Z

@mkue The issues have been resolved. As discussed, the navigation bar has become quite complex over time, and there’s certainly room for simplification. However, it functions as expected for now. I’ve tested it on an iPad as well as on a Mac using Safari, Chrome, and Firefox.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

website/src/components/navbar/navbar-client.tsx (1)

338-345: Flag dimension adjustments.
Changing from 24px to 20px can mitigate layout issues on narrower displays. Validate if the smaller size remains recognizable.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbd15aa and c158311.

📒 Files selected for processing (3)

shared/locales/fr/website-common.json (1 hunks)
website/src/components/navbar/navbar-client.tsx (5 hunks)
website/src/components/navbar/navbar.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

website/src/components/navbar/navbar.tsx

🔇 Additional comments (6)

website/src/components/navbar/navbar-client.tsx (5)

279-290: Streamlined transitions and spacing look good.
Hiding the navigation by default (h-20) and then expanding on hover (h-60) is a neat approach, but make sure the transition doesn't create unexpected layout shifts on slow networks.

300-305: Proper spacing and hover for "our-work" dropdown.
The whitespace-nowrap px-2 class prevents multi-line wrapping, which is ideal for keeping items tidy. Looks effective.

313-317: Consistent approach for "about-us" dropdown.
Same pattern with whitespace-nowrap px-2 ensures all nav items align similarly. This reduces clutter on smaller screens.

325-329: Transparency dropdown logic matches other sections.
Uniform handling of sub-navigation fosters a cohesive user experience.

Line range hint 353-392: Enhanced language, region, and currency selection.
Using grid for the dropdown is an excellent way to organize items. Ensure that focusing or tabbing through these items remains accessible, especially when the dropdown transitions from hidden to visible.

shared/locales/fr/website-common.json (1)

11-11: Translation text updated.
Changing "Modèle à 100 %" to "Notre promesse" aligns with more intuitive messaging for French speakers.

mkue

Very nice!

Fixing various screen views

304bd29

Prettified Code!

3a537b5

vercel bot deployed to Preview January 4, 2025 19:32 View deployment

ssandino and others added 7 commits January 4, 2025 20:55

Small fixes

9e8d9ce

Merge remote-tracking branch 'origin/sandino/nav-wip' into sandino/na…

d4be033

…v-wip # Conflicts: # website/src/components/navbar/navbar-client.tsx

Test fix (as it doesn't show on local)

851bd0f

Prettified Code!

deb2f4d

Test fix (as it doesn't show on local)

3087157

Merge remote-tracking branch 'origin/sandino/nav-wip' into sandino/na…

7d7a0dc

…v-wip # Conflicts: # website/src/components/navbar/navbar-client.tsx

Prettified Code!

1128753

vercel bot deployed to Preview January 4, 2025 21:43 View deployment

ssandino and others added 3 commits January 4, 2025 22:48

Clean up

ffc6117

Merge remote-tracking branch 'origin/sandino/nav-wip' into sandino/na…

1ce8e35

…v-wip # Conflicts: # website/src/components/navbar/navbar-client.tsx

Prettified Code!

93cab2f

vercel bot deployed to Preview January 4, 2025 21:55 View deployment

Clean up

c158311

vercel bot deployed to Preview January 4, 2025 22:03 View deployment

ssandino marked this pull request as ready for review January 4, 2025 22:08

ssandino requested review from andrashee, mkue and socialincome-dev as code owners January 4, 2025 22:08

coderabbitai bot reviewed Jan 4, 2025

View reviewed changes

mkue approved these changes Jan 5, 2025

View reviewed changes

mkue merged commit 55b7607 into main Jan 5, 2025
16 checks passed

mkue deleted the sandino/nav-wip branch January 5, 2025 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Website: Nav bar optimization #1000

Website: Nav bar optimization #1000

ssandino commented Jan 4, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jan 4, 2025 •

edited

Loading

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jan 4, 2025 •

edited

Loading

ssandino commented Jan 4, 2025

coderabbitai bot left a comment

mkue left a comment

Website: Nav bar optimization #1000

Website: Nav bar optimization #1000

Conversation

ssandino commented Jan 4, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Jan 4, 2025 • edited Loading

coderabbitai bot commented Jan 4, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jan 4, 2025 • edited Loading

ssandino commented Jan 4, 2025

coderabbitai bot left a comment

Choose a reason for hiding this comment

mkue left a comment

Choose a reason for hiding this comment

ssandino commented Jan 4, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jan 4, 2025 •

edited

Loading

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jan 4, 2025 •

edited

Loading