diff --git a/src/snyk/common/views/issueTreeProvider.ts b/src/snyk/common/views/issueTreeProvider.ts index 159dc5c05..9d89ed09b 100644 --- a/src/snyk/common/views/issueTreeProvider.ts +++ b/src/snyk/common/views/issueTreeProvider.ts @@ -294,7 +294,10 @@ export abstract class ProductIssueTreeProvider extends AnalysisTreeNodeProvid } protected getIssueFoundText(nIssues: number, _: number): string { - return `Snyk found ${!nIssues ? 'no issues! ✅' : `${nIssues} issue${nIssues === 1 ? '' : 's'}`}`; + if (!nIssues) { + return '✅ Congrats! No issues found!'; + } + return `Snyk found ${nIssues} issue${nIssues === 1 ? '' : 's'}`; } protected getIssueDescriptionText(dir: string | undefined, issueCount: number): string | undefined { diff --git a/src/snyk/snykCode/views/securityIssueTreeProvider.ts b/src/snyk/snykCode/views/securityIssueTreeProvider.ts index a806a4584..6ea4e2aaa 100644 --- a/src/snyk/snykCode/views/securityIssueTreeProvider.ts +++ b/src/snyk/snykCode/views/securityIssueTreeProvider.ts @@ -55,7 +55,7 @@ export default class CodeSecurityIssueTreeProvider extends IssueTreeProvider { } return text; } else { - return '✅ Congrats! No vulnerabilities found!'; + return '✅ Congrats! No issues found!'; } } } diff --git a/src/snyk/snykIac/views/iacIssueTreeProvider.ts b/src/snyk/snykIac/views/iacIssueTreeProvider.ts index 9af547e99..2a676ee33 100644 --- a/src/snyk/snykIac/views/iacIssueTreeProvider.ts +++ b/src/snyk/snykIac/views/iacIssueTreeProvider.ts @@ -49,7 +49,10 @@ export default class IacIssueTreeProvider extends ProductIssueTreeProvider[]): Issue[] { diff --git a/src/snyk/snykOss/constants/messages.ts b/src/snyk/snykOss/constants/messages.ts index ef01e4ddf..a0af4b11c 100644 --- a/src/snyk/snykOss/constants/messages.ts +++ b/src/snyk/snykOss/constants/messages.ts @@ -23,7 +23,7 @@ export const messages = { treeView: { cookingDependencies: 'Scanning...', runTest: 'Run scan for Open Source security vulnerabilities.', - noVulnerabilitiesFound: ' ✅ Congrats! Snyk found no vulnerabilities.', + noVulnerabilitiesFound: ' ✅ Congrats! No issues found!', singleVulnerabilityFound: 'Snyk found 1 vulnerability', vulnerability: 'vulnerability', vulnerabilities: 'vulnerabilities', diff --git a/src/snyk/snykOss/providers/ossVulnerabilityTreeProvider.ts b/src/snyk/snykOss/providers/ossVulnerabilityTreeProvider.ts index 5fdd38183..ccd1c06df 100644 --- a/src/snyk/snykOss/providers/ossVulnerabilityTreeProvider.ts +++ b/src/snyk/snykOss/providers/ossVulnerabilityTreeProvider.ts @@ -154,9 +154,10 @@ export default class OssIssueTreeProvider extends ProductIssueTreeProvider[]): Issue[] { diff --git a/src/test/integration/issueTreeProvider.test.ts b/src/test/integration/issueTreeProvider.test.ts index b0263aca6..c982d262b 100644 --- a/src/test/integration/issueTreeProvider.test.ts +++ b/src/test/integration/issueTreeProvider.test.ts @@ -82,7 +82,7 @@ suite('Code Issue Tree Provider', () => { sinon.stub(issueTreeProvider, 'getResultNodes').returns([]); const rootChildren = issueTreeProvider.getRootChildren(); strictEqual(rootChildren.length, 2); - strictEqual(rootChildren[0].label, 'Snyk found no issues! ✅'); + strictEqual(rootChildren[0].label, '✅ Congrats! No issues found!'); strictEqual(rootChildren[1].label, 'There are no vulnerabilities fixable by Snyk DeepCode AI'); });