Merge pull request #610 from snyk/fix/do-not-overwrite-values

fix: do not overwrite values [CLI-543]

lib/sub-process.ts

@@ -12,7 +12,7 @@ function execute(
   args: string[],
   options?,
 ): Promise<CmdOutput> {
-  const spawnOptions: any = { shell: true, env: process.env };
+  const spawnOptions: any = { shell: true, env: { ...process.env } };
   if (options && options.cwd) {
     spawnOptions.cwd = options.cwd;
   }

test/lib/sub-process.spec.ts

@@ -0,0 +1,34 @@
+import { execute } from "../../lib/sub-process";
+
+describe("sub-process", () => {
+  let preTestEnv: NodeJS.ProcessEnv;
+
+  beforeEach(() => {
+    preTestEnv = { ...process.env };
+  });
+
+  afterEach(() => {
+    process.env = { ...preTestEnv };
+  });
+
+  it("restores proxy environment", async () => {
+    process.env.SNYK_SYSTEM_HTTPS_PROXY = "https://1.1.1.1";
+    process.env.SNYK_SYSTEM_HTTP_PROXY = "http://2.2.2.2";
+    process.env.SNYK_SYSTEM_NO_PROXY = "snyk.com";
+
+    process.env.HTTPS_PROXY = "http://127.0.0.1";
+    process.env.HTTP_PROXY = "http://127.0.0.1";
+    process.env.NO_PROXY = "example.com";
+
+    const { stdout } = await execute("env", [], {});
+
+    expect(stdout).toContain("HTTPS_PROXY=https://1.1.1.1");
+    expect(process.env.HTTPS_PROXY).toStrictEqual("http://127.0.0.1");
+
+    expect(stdout).toContain("HTTP_PROXY=http://2.2.2.2");
+    expect(process.env.HTTP_PROXY).toStrictEqual("http://127.0.0.1");
+
+    expect(stdout).toContain("NO_PROXY=snyk.com");
+    expect(process.env.NO_PROXY).toStrictEqual("example.com");
+  });
+});