fix: resolve relative bundle file path correctly [ROAD-329] #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvi3d
reviewed
Oct 15, 2021
| const linuxPath = '/home/user/Git/goof/routes/index.js'; | ||
| expect(getBundleFilePath(linuxPath, baseDir)).toEqual(linuxPath); | ||
|
|
||
| const windowsPath = 'C:\\Users\\user\\Git\\goof\\index.js'; |
There was a problem hiding this comment.
i'm afraid our engine will fail, if it receives this path.
can you please also add an explicit test for it?
There was a problem hiding this comment.
ah, stop, this is a reverse process. all good
Arvi3d
approved these changes
Oct 15, 2021
|
🎉 This PR is included in version 4.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves the issue of determining relative bundle file paths when many folders are passed for the analysis.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
When
getBundleFilePath()is called for multiple folders analysis (e.g. VS Code workspace with many folders), it is passed withbaseDir = ''argument that makes relative path resolution fail on Linux within VS Code extension currently.The following behaviour is observed at the moment:
args:
baseDir='', filePath='/home/user/Downloads/goof-master/routes/index.js'returns:
'Downloads/goof-master/routes/index.js'path.relative()relies onprocess.cwd()that can be different based on where Node.js process was started. For VS Code, If this code is called on Mac OS,process.cwd()defaults to/, however Linux defaults to the user directory e.g./home/user. Thus wrong analysis results file paths for bundles will be returned.Relevant Jira ticket: https://snyksec.atlassian.net/browse/ROAD-329
Screenshots
Additional questions