Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Snyk issue counter to inline badge format #199

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: Update Snyk issue counter to inline badge format #199

merged 1 commit into from
Apr 16, 2024

Conversation

stefanbuck-snyk
Copy link
Collaborator

@stefanbuck-snyk stefanbuck-snyk commented Apr 16, 2024 •
edited
Loading

  • Tests written and linted ℹ︎
  • Commit history is tidy & follows Contributing guidelines ℹ︎

What this does

This change aims to enhance the user experience by updating the Snyk issue counter from a circular graph to an inline badge format, which not only consumes less space but also enhances the visual appeal of the interface.

Notes for the reviewer

  • This PR is based off feat: migrate to MUIv5 #198, therefore ignore commit 7d55931
  • Replaced circular graph with an inline badge counter
  • Update loading state to match loading state of entity component (also looks better IMHO)
  • Manual testing was done to ensure the correct rendering of the inline badge counter

TODO

Screenshots

Overview Before

old_overview

Overview New

new_overview

Overview loading state (before)

old_overview_loading

Overview loading state (new)

new_overview_loading

Entity (before)

image

Entity (new)

new_entity

Dark mode

image

@stefanbuck-snyk stefanbuck-snyk requested a review from a team as a code owner April 16, 2024 11:07
@cla-bot cla-bot bot added the cla-signed label Apr 16, 2024
SnykOleg
SnykOleg previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@SnykOleg SnykOleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💪

aarlaud
aarlaud previously approved these changes Apr 16, 2024
View reviewed changes
@stefanbuck-snyk stefanbuck-snyk dismissed stale reviews from aarlaud and SnykOleg via 4fb27ee April 16, 2024 12:35
@stefanbuck-snyk stefanbuck-snyk merged commit 4a8f5e8 into develop Apr 16, 2024
3 checks passed
@stefanbuck-snyk stefanbuck-snyk deleted the card-style branch April 16, 2024 13:01
stefanbuck-snyk added a commit that referenced this pull request Apr 17, 2024
@stefanbuck-snyk
Sync main with develop branch (#200)
487cffa 
* feat: set User-Agent version based on package version (#197)

* feat: migrate to MUIv5 (#198)

* feat: align counter component with Snyk UI (#199)
stefanbuck-snyk added a commit that referenced this pull request Apr 17, 2024
@stefanbuck-snyk
feat: align counter component with Snyk UI (#199)
0b0841f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarlaud aarlaud aarlaud approved these changes

@SnykOleg SnykOleg SnykOleg left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanbuck-snyk @aarlaud @SnykOleg