Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does keter depend on network-conduit-tls? #83

Closed
ygale opened this issue Mar 10, 2015 · 3 comments
Closed

Why does keter depend on network-conduit-tls? #83

ygale opened this issue Mar 10, 2015 · 3 comments

Comments

@ygale
Copy link

ygale commented Mar 10, 2015

The cabal file for keter specifies a dependency on network-conduit-tls, but a quick grep through the source code didn't turn up any import of Data.Conduit.Network.TLS. Is that dependency really needed?

The reason I am asking is that I just added chain certificate support to keter via #82, using chain certificate support I previously added to tls and warp-tls. However, network-conduit-tls does not yet support chain certificates in its credentials. My tests indicate that keter does seem to support chain certificates now without any change to network-conduit-tls. And anyway, it's always a good idea to get rid of unneeded dependencies.

@snoyberg
Copy link
Owner

It could be there for historical purposes. If you can compile it without dependency, please feel free to send a PR.

@creichert
Copy link
Collaborator

Fixed now. Thanks again!

@ygale
Copy link
Author

ygale commented Mar 10, 2015

I actually went ahead and added chain certificate support to network-conduit-tls, for completeness, while it's still fresh in my mind, via snoyberg/conduit#203. But if the dependency isn't needed here, better to get rid of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants