Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin to send requests with user ID to a Kantar FocalMeter endpoint (close #1133) #1243

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Add plugin to send requests with user ID to a Kantar FocalMeter endpoint (close #1133) #1243

merged 3 commits into from
Oct 5, 2023

Conversation

matus-tomlein
Copy link
Contributor

Issue #1133

This PR has already been partly reviewed in #1134. Since then we have published it as a pre-release for external testing, now the testing has confirmed that we can release it in a stable tracker release.

Since the reviewed PR, there has been one small change – we have made it possible to pass processUserId callback in the plugin configuration that enables users to apply custom hashing on top of the user identifier.

Documentation for this is here.

@matus-tomlein
Add plugin to send requests with user ID to a Kantar FocalMeter endpo…
a5d93dc 
…int (close #1133)

PR #1134
# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	common/config/rush/repo-state.json
#	rush.json

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	common/config/rush/repo-state.json
#	rush.json
@matus-tomlein
Add processUserId callback to transform the userId such as for hashing
d6d01cd
@matus-tomlein
Update tracker version in FocalMeter plugin
2771c48
@bundlemon
Copy link

bundlemon bot commented Oct 5, 2023

BundleMon

Files added (6)
Status Path Size Limits
✅ libraries/browser-tracker-core/dist/index.mod
ule.js
 +25.32KB 26KB / +10%
✅ trackers/javascript-tracker/dist/sp.js
 +24.18KB 25KB / +10%
✅ trackers/javascript-tracker/dist/sp.lite.js
 +14.86KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.umd.min.j
s
 +14.7KB 15KB / +10%
✅ libraries/tracker-core/dist/index.module.js
 +13.35KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.module.js
 +3.51KB 5KB / +10%

Total files change +95.92KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@matus-tomlein matus-tomlein merged commit bb28121 into release/3.16.0 Oct 5, 2023
2 checks passed
@matus-tomlein matus-tomlein deleted the issue/1133-focalmeter_plugin branch October 5, 2023 12:15
matus-tomlein added a commit that referenced this pull request Oct 16, 2023
@matus-tomlein
Add plugin to send requests with user ID to a Kantar FocalMeter endpo…
41d3a75 
…int (close #1133)

PR #1243 and #1134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igneel64 igneel64 igneel64 approved these changes

@greg-el greg-el Awaiting requested review from greg-el

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matus-tomlein @igneel64