-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashing if we do not use InstallReferrer library in consumer application #682
Comments
No,actually we do not prefer to implement InstallReferrer in our application, are you going to provide required dependency transitively? |
Hi @Prithuld, thanks for raising this! The tracker does not have a transitive dependency on the InstallReferrer because we wanted to let users who don't wish to track the information provided by the InstallReferrer to use the tracker without any extra dependencies. Tracking the referrer information from the InstallReferrer library is an optional feature that is only enabled in case the dependency is available in the app. Does that make sense? |
ok thanks.. what will be the impact if we do not implement InstallReferrer ? which feature we will loose? |
@Prithuld the impact is the |
Gotcha, it seems this information we need but how do you feel to include it? I mean you can take user input to track information in configuration (in may be Snowplow object creation ,not sure may be)without removing the library. Ideal case consumer application does not want to use two library for same purpose. We can make this feature optional different way I feel , do you think excluding the library is only option? |
Describe the bug
Our app is crashing and it needs InstallReferrer library to be added in our application to get it fixed.
To Reproduce
Aleady background is mentioned #647
Expected behavior
We do not want to add any additional library in our application to support snowplow, ideally snowplow should fix it by passing the dependency transitively .
We just want to use snowplow library (no additional one to support it 😞 )
Screenshots
Mentioned #647
Device informatoin (please complete the following information):
The text was updated successfully, but these errors were encountered: