Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the possibility to emit enriched events invalid against atomic schema #551

Open
benjben opened this issue Feb 9, 2022 · 0 comments

Comments

@benjben
Copy link
Contributor

benjben commented Feb 9, 2022

Remove the feature flag acceptInvalid in the configuration and consider it as always false.

acceptInvalid and invalidCount can be removed from these 2 functions :

  1. In EnrichmentManager :
def enrichEvent[F[_]: Monad: RegistryLookup: Clock](
    registry: EnrichmentRegistry[F],
    client: Client[F, Json],
    processor: Processor,
    etlTstamp: DateTime,
    raw: RawEvent,
    acceptInvalid: Boolean,
    invalidCount: F[Unit]
  ): EitherT[F, BadRow, EnrichedEvent] =
  1. In EtlPipeline :
 def processEvents[F[_]: Monad: RegistryLookup: Clock: HttpClient](
    adapterRegistry: AdapterRegistry,
    enrichmentRegistry: EnrichmentRegistry[F],
    client: Client[F, Json],
    processor: Processor,
    etlTstamp: DateTime,
    input: ValidatedNel[BadRow, Option[CollectorPayload]],
    acceptInvalid: Boolean,
    invalidCount: F[Unit]
  ): F[List[Validated[BadRow, EnrichedEvent]]] =

More details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant