Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Long named items not logged #466

Open
1 task done
Shepelzz opened this issue Dec 4, 2024 · 1 comment
Open
1 task done

[BUG] Long named items not logged #466

Shepelzz opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working next update

Comments

@Shepelzz
Copy link

Shepelzz commented Dec 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Type of bug

Error in console

Environment

- Server Version: 1.20.1
- Shop Version: 1.9.1.2

Server startup log

not needed

Shop config files

not needed

Error log (if applicable)

https://gist.github.com/Shepelzz/59dc65643b21d420342c9d0a07300283

Bug description

You need to increase size of mysql 'item' column because there are items more than char(32) length.
TIDE_ARMOR_TRIM_SMITHING_TEMPLATE for example.

Steps to reproduce

  • configure mysql logging
  • create shop selling TIDE_ARMOR_TRIM_SMITHING_TEMPLATE
  • buy item

Expected behaviour

  • transaction was saved to mysql

Actual behaviour

  • transaction was not saved to mysql
  • error in console

Other information

No response

@Shepelzz Shepelzz added the bug Something isn't working label Dec 4, 2024
@OstlerDev
Copy link
Collaborator

This is fixed in the new version 1.10.0 that will be coming out in the next couple weeks (hopefully). I have changed the column to remove the character limit, and it will now log the entire item data (in base64) to include all enchantments and custom NBT data!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next update
Projects
None yet
Development

No branches or pull requests

2 participants