Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-18844419 Change the aliasing fn type to be an enum instead of optional boolean #2712

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

sfc-gh-vbudati
Copy link
Contributor

@sfc-gh-vbudati sfc-gh-vbudati commented Dec 4, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
    Fixes SNOW-18844419

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

Change the aliasing fn type to be an enum instead of optional boolean to differentiate between as_, name, and alias.

@sfc-gh-vbudati sfc-gh-vbudati added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-ast Change materially affects the Snowpark AST labels Dec 4, 2024
@sfc-gh-vbudati sfc-gh-vbudati requested review from a team as code owners December 4, 2024 01:58
@@ -15,7 +15,7 @@ elif [ -n "$1" ]
fi
set -euxo pipefail

SCRIPT_DIR=$(dirname "$0")
SCRIPT_DIR=$(dirname "$0")/generated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is now invalid. There's no more make-ast. We need to run bazel build //Snowpark/ast:py_ast.

@sfc-gh-vbudati sfc-gh-vbudati merged commit ae1fe68 into main Dec 11, 2024
42 checks passed
@sfc-gh-vbudati sfc-gh-vbudati deleted the vbudati/SNOW-18844419-fix-column-alias branch December 11, 2024 01:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-ast Change materially affects the Snowpark AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants