-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-18844419 Change the aliasing fn type to be an enum instead of optional boolean #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-vbudati
added
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
snowpark-ast
Change materially affects the Snowpark AST
labels
Dec 4, 2024
sfc-gh-vbudati
requested review from
sfc-gh-smirzaei,
sfc-gh-jdu and
sfc-gh-yixie
December 4, 2024 01:58
8 tasks
@@ -15,7 +15,7 @@ elif [ -n "$1" ] | |||
fi | |||
set -euxo pipefail | |||
|
|||
SCRIPT_DIR=$(dirname "$0") | |||
SCRIPT_DIR=$(dirname "$0")/generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is now invalid. There's no more make-ast. We need to run bazel build //Snowpark/ast:py_ast
.
sfc-gh-azwiegincew
approved these changes
Dec 5, 2024
sfc-gh-oplaton
approved these changes
Dec 5, 2024
…nowflakedb/snowpark-python into vbudati/SNOW-18844419-fix-column-alias
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
snowpark-ast
Change materially affects the Snowpark AST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-18844419
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Change the aliasing fn type to be an enum instead of optional boolean to differentiate between as_, name, and alias.