Adding a compatibility mode to ease migration usages #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mrojas
requested review from
sfc-gh-jdu,
sfc-gh-yixie and
sfc-gh-yuwang
CHANGELOG.md
Outdated
Comment on lines
1074
to
1077
| ``` | ||
|
|
||
| - Fixed a bug in `Session.create_dataframe` that the non-nullable field in a schema is not respected for boolean type. Note that this fix is only effective when the user has the privilege to create a temp table. | ||
| - Fixed a bug in SQL simplifier where non-select statements in `session.sql` dropped a SQL query when used with `limit()`. | ||
| - Fixed a bug that raised an exception when session parameter `ERROR_ON_NONDETERMINISTIC_UPDATE` is true. |
There was a problem hiding this comment.
there are too many changes in changelog. are they really necessary? can we roll them back?
There was a problem hiding this comment.
Those changes were already in main branch.
sfc-gh-aalam
approved these changes
Nov 26, 2024
Co-authored-by: Afroz Alam <[email protected]>
sfc-gh-aalam
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1824419, SNOW-1824418: Enable setting properties in the RuntimeConf / session.conf object for migration scenarions #2672
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
This code, introduces a flag which once set, allows storing/getting custom values