Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-931105: Add createSessionlessTelemetry(CloseableHttpClient, String) method #1527

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Oct 12, 2023

Overview

SNOW-931105
Issue 698: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/698

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-931105: NoSuchMethodError when using snowflake-ingest-sdk 2.0.3 #1524

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Add an additional overload of the createSessionlessTelemetry method with 2 parameters and by default, it uses "KEYPAIR_JWT" as the auth type. This fix helps the snowflake-ingest-sdk to work correctly with the latest version of the driver.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl changed the title add createSessionlessTelemetry(CloseableHttpClient, String) method SNOW-931105: Add createSessionlessTelemetry(CloseableHttpClient, String) method Oct 12, 2023
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review October 12, 2023 22:24
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner October 12, 2023 22:24
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit f65ee55 into master Oct 13, 2023
12 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the SNOW-931105-createSessionlessTelemetry branch October 13, 2023 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-931105: NoSuchMethodError when using snowflake-ingest-sdk 2.0.3
3 participants