SNOW-1700248 Revert turning native arrow boolean primitives lowercase #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroducing a breaking change. Structured types' booleans string representation will remain lowercase to preserve JSON-compatibility
sfc-gh-mkubik
changed the title
|
Do you guys have plans on how to improve the release process to avoid such breaking changes in the future? |
In terms of release process I believe the BPTP validation does that and there won't be a new version of the driver released with such changes. It'd make sense to include similar checks on the PRs to verify before merging to master. |
|
Please merge this PR. This causes 30+ test failures every run for us. |
sfc-gh-mkubik
deleted the
SNOW-1374896-fix-failing-bptp-pipeline-change-boolean-string-case
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert turning native arrow boolean primitives lowercase (changed in PR#1882) to prevent introducing a breaking change.
Structured types' booleans string representation will remain lowercase to preserve JSON-compatibility
Overview
SNOW-1374896
SNOW-1700248
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:I reverted the global boolean case change and implemented a structured type string builder one. Primitive booleans will remain UPPERCASED while booleans within structured types will be lowercased to provide JSON compatibility