Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1491028 : Snowflake JDBC Driver 4.2 compliant issue. #1850

Conversation

sfc-gh-ext-simba-vb
Copy link
Collaborator

Overview

SNOW-1491028

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

Issue 1016 - https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/1016

  1. Currently the setHoldability method always throws the exception. According to the docs we should throw the exception only when the given holdability is no supported - in other cases it should be no-op.
    Now Driver will throw SnowflakeLoggedFeatureNotSupportedException only when holdability parameter is HOLD_CURSORS_OVER_COMMIT
  2. If the connection is closed or given value is outside of the possible range in the standard, the driver will throw SQLException.

Copy link

github-actions bot commented Jul 31, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (sfc-gh-ext-simba-vb)[https://github.com/sfc-gh-ext-simba-vb]
❌ @Vikramsinh.Barbade
Vikramsinh.Barbade seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Signed-off-by: sfc-gh-ext-simba-vb <[email protected]>
@sfc-gh-ext-simba-vb
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb deleted the SNOW-1491028_Snowflake_JDBC_Driver_4.2_compliant_issue branch August 2, 2024 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant