SNOW-1322004: Upgrade to Arrow 15.0.2 in snowflake-jdbc #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -477,6 +477,10 @@ | |||
| <pattern>org.threeten</pattern> | |||
| <shadedPattern>${shadeBase}.threeten</shadedPattern> | |||
| </relocation> | |||
| <relocation> | |||
| <pattern>org.slf4j</pattern> | |||
There was a problem hiding this comment.
let's not shade slf4j - arrow should not need this dependency
| @@ -553,6 +561,9 @@ | |||
| <exclude>arrow-git.properties</exclude> | |||
| <exclude>google-http-client.properties</exclude> | |||
| <exclude>pipes-fork-server-default-log4j2.xml</exclude> | |||
| <exclude>about.html</exclude> | |||
| <exclude>LICENSE-EDL-1.0.txt</exclude> | |||
There was a problem hiding this comment.
according to the licence we should include this files?
| @@ -14,7 +14,7 @@ | |||
| <parent> | |||
| <groupId>org.apache.arrow</groupId> | |||
| <artifactId>arrow-java-root</artifactId> | |||
| <version>10.0.1</version> | |||
| <version>15.0.2</version> | |||
There was a problem hiding this comment.
let's update also dependencies/README.md
| @@ -385,7 +386,6 @@ | |||
| <groupId>org.slf4j</groupId> | |||
| <artifactId>slf4j-api</artifactId> | |||
| <version>${slf4j.version}</version> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
let's keep it provided
| @@ -927,6 +931,10 @@ | |||
| <pattern>org.codehaus</pattern> | |||
| <shadedPattern>${shadeBase}.org.codehaus</shadedPattern> | |||
| </relocation> | |||
| <relocation> | |||
| <pattern>org.slf4j</pattern> | |||
| <shadedPattern>${shadeBase}.org.slf4j</shadedPattern> | |||
There was a problem hiding this comment.
let's not shade slf4j
| @@ -967,6 +975,9 @@ | |||
| <exclude>arrow-git.properties</exclude> | |||
| <exclude>google-http-client.properties</exclude> | |||
| <exclude>storage.v1.json</exclude> | |||
| <exclude>about.html</exclude> | |||
| <exclude>LICENSE-EDL-1.0.txt</exclude> | |||
| <exclude>LICENSE-EPL-1.0.txt</exclude> | |||
There was a problem hiding this comment.
we should include licenses?
| <google.cloud.core.version>2.21.0</google.cloud.core.version> | ||
| <google.cloud.storage.version>2.22.6</google.cloud.storage.version> | ||
| <google.flatbuffers.version>1.12.0</google.flatbuffers.version> | ||
| <google.flatbuffers.version>23.5.26</google.flatbuffers.version> |
There was a problem hiding this comment.
don't we need to change any other google library?
|
We are able to upgrade Arrow Version to 17.0.0. I made a different PR for that. Let's move on #1854 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1322004
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.