SNOW-969200: Remove to look into temp directory for security reason (#…

…1558) * Remove to look into temp directory for security reason * Removed the code as suggested by code review feedback
snowflakedb · Nov 14, 2023 · 6ca726b · 6ca726b
1 parent b5ed386
commit 6ca726b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 23 deletions.
diff --git a/src/main/java/net/snowflake/client/config/SFClientConfigParser.java b/src/main/java/net/snowflake/client/config/SFClientConfigParser.java
@@ -50,13 +50,6 @@ public static SFClientConfig loadSFClientConfig(String configFilePath) throws IO
             Paths.get(systemGetProperty("user.home"), SF_CLIENT_CONFIG_FILE_NAME).toString();
         if (Files.exists(Paths.get(userHomeFilePath))) {
           derivedConfigFilePath = userHomeFilePath;
-        } else {
-          // 5. Read SF_CLIENT_CONFIG_FILE_NAME if it is present in tmpdir.
-          String tmpFilePath =
-              Paths.get(systemGetProperty("java.io.tmpdir"), SF_CLIENT_CONFIG_FILE_NAME).toString();
-          if (Files.exists(Paths.get(tmpFilePath))) {
-            derivedConfigFilePath = tmpFilePath;
-          }
         }
       }
     }

diff --git a/src/test/java/net/snowflake/client/config/SFClientConfigParserTest.java b/src/test/java/net/snowflake/client/config/SFClientConfigParserTest.java
@@ -115,22 +115,6 @@ public void testloadSFClientConfigWithUserHome() {
     }
   }
 
-  @Test
-  public void testloadSFClientConfigWithTmpDirectory() {
-    Path configFilePath =
-        Paths.get(systemGetProperty("java.io.tmpdir"), SF_CLIENT_CONFIG_FILE_NAME);
-    try {
-      Files.write(configFilePath, CONFIG_JSON.getBytes());
-      SFClientConfig actualConfig = SFClientConfigParser.loadSFClientConfig(null);
-      assertEquals("info", actualConfig.getCommonProps().getLogLevel());
-      assertEquals("/jdbc.log", actualConfig.getCommonProps().getLogPath());
-
-      Files.delete(configFilePath);
-    } catch (IOException e) {
-      fail("testloadSFClientConfigWithTmpDirectory failed");
-    }
-  }
-
   @Test
   public void testloadSFClientNoConditionsMatch() throws IOException {
     SFClientConfig actualConfig = SFClientConfigParser.loadSFClientConfig(null);