You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
and not via a hack in the actual library that breaks the driver for anyone that has opentelemetry installed but not in-use.
I hope that this issue results in that change being reverted, and the original requestor of the feature gets this done properly in the open-telemetry project.
Can you set logging to DEBUG and collect the logs?
We already have it at DEBUG and that's the problem.
The text was updated successfully, but these errors were encountered:
lattwood
changed the title
SNOW-1763555: OpenTelemetry integration done noisily/wrong
SNOW-1763555: OpenTelemetry integration utterly breaks driver if using DataDog
Oct 25, 2024
User has to import opentelemetry and configure it to have this. This code executes only if the import succeeds which requires user to import and configure opentelemetry.
specifically this is the erroneous assumption, there are many ways the import can fail.
Python version
N/A
Operating system and processor architecture
N/A
Installed packages
What did you do?
I used the driver w/ Datadog APM, which installs the opentelemetry packages that are used as the check to see if we can inject trace context.
With DataDog, this gets happens on every query, and it fails to run.
This is because the only exception caught is ModuleNotFoundError, and opentracing is throwing a ValueError which isn't getting caught.
(please forgive any typos, I copied the backtrace from a screenshot)
What did you expect to see?
I would expect that opentelemetry integration would be done via this- https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation
and not via a hack in the actual library that breaks the driver for anyone that has opentelemetry installed but not in-use.
I hope that this issue results in that change being reverted, and the original requestor of the feature gets this done properly in the open-telemetry project.
Can you set logging to DEBUG and collect the logs?
We already have it at DEBUG and that's the problem.
The text was updated successfully, but these errors were encountered: