Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1769573 Add support for describeOnly #945

Merged
merged 7 commits into from
Nov 7, 2024
Merged

SNOW-1769573 Add support for describeOnly #945

merged 7 commits into from
Nov 7, 2024

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Nov 4, 2024 •
edited
Loading

Description

SNOW-1769573 - Add support for describeOnly.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner November 4, 2024 14:45
sfc-gh-pbulawa
sfc-gh-pbulawa reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also check a success flow?

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (081d28b) to head (985dcfb).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   88.87%   88.88%   +0.01%     
==========================================
  Files          69       69              
  Lines        6677     6685       +8     
==========================================
+ Hits         5934     5942       +8     
  Misses        743      743

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-dprzybysz
sfc-gh-dprzybysz requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's add SNOW-XXX to the PR name
  2. Let's add more tests when describe only is passed

@sfc-gh-pmotacki sfc-gh-pmotacki changed the title Add support for describeOnly SNOW-1769573 Add support for describeOnly Nov 5, 2024
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Nov 5, 2024
View reviewed changes
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 00e3b95 into master Nov 7, 2024
56 of 57 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the test_pr_941 branch November 7, 2024 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-fpawlowski sfc-gh-fpawlowski sfc-gh-fpawlowski approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-fpawlowski @gabegorelick