Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1756807: Add note about GCP regional endpoints #942

Merged

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

SNOW-175680

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner October 29, 2024 13:02
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (c748d3b) to head (751f2a6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   88.90%   88.92%   +0.01%     
==========================================
  Files          66       66              
  Lines        6455     6455              
==========================================
+ Hits         5739     5740       +1     
+ Misses        716      715       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 4f85d59 into master Oct 30, 2024
57 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1756807-add-note-about-gcp-regional-endpoints branch October 30, 2024 09:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants