Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1658878 unhandled rejection at promise the callback argument must be of type function. received undefined #939

Merged
merged 14 commits into from
Nov 4, 2024
Merged

SNOW-1658878 unhandled rejection at promise the callback argument must be of type function. received undefined #939

merged 14 commits into from
Nov 4, 2024

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Oct 23, 2024
@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review October 23, 2024 07:58
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner October 23, 2024 07:58
This was referenced Oct 23, 2024
Closed
Closed
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Oct 23, 2024
View reviewed changes
test/integration/testConnection.js Outdated Show resolved Hide resolved
test/integration/testConnection.js Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (b45ac51) to head (852698f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   88.90%   88.97%   +0.06%     
==========================================
  Files          66       67       +1     
  Lines        6455     6459       +4     
==========================================
+ Hits         5739     5747       +8     
+ Misses        716      712       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Snow 1658878 unhandled rejection at promise the callback argument must be of type function. received undefined SNOW-1658878 unhandled rejection at promise the callback argument must be of type function. received undefined Oct 29, 2024
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - callback function for heartbeat reverted to self. Test…
3df8afc 
…s for correct promisifying of a connection added.
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - removed unused libraries import
6682803
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - code formatting fixed
6263b1a
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - code formatting fixed
70cad79
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - Tests moved to describe. Refactored assertions
4bb45cf
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - Fully working unit test to avoid connect callback bein…
e7acf79 
…g called in heartbeat.
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - Annotated long-running tests as manual.
74c8fb1
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - Removed redundant keep alive tests and added comments
8490dd4
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1658878 - Code formatted
2784ec7
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1633278-Connection-Layer - assertions extracted to after statement
4be2013
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1633278-Connection-Layer - spelling fixed
b8b83c9
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1633278-Connection-Layer - setup and cleanup for each test added
574bdfc
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1633278-Connection-Layer - Refactored destruction assertion
edf31ef
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1633278-Connection-Layer - Reverted connectCallback renaming
852698f
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1658878-Unhandled-Rejection-at-Promise-The-callback-argument-must-be-of-type-function.-Received-undefined branch from b7dd57a to 852698f Compare November 4, 2024 09:01
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit c77f3d6 into master Nov 4, 2024
58 of 59 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1658878-Unhandled-Rejection-at-Promise-The-callback-argument-must-be-of-type-function.-Received-undefined branch November 4, 2024 10:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-fpawlowski @sfc-gh-dprzybysz @sfc-gh-pmotacki @sfc-gh-dheyman