Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-964608: Fix response handling for auth_okta #693

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Nov 8, 2023

Description

Fix response handling in auth_okta as the axios v.1.6.0 returns it differently than previous one.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner November 8, 2023 15:12
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #693 (faedff3) into master (645faeb) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   87.33%   87.75%   +0.41%     
==========================================
  Files          61       61              
  Lines        5756     5756              
==========================================
+ Hits         5027     5051      +24     
+ Misses        729      705      -24     
Files Coverage Δ
lib/authentication/auth_okta.js 87.27% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit a073e14 into master Nov 9, 2023
43 of 44 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-964608-fix-response-handling branch November 9, 2023 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants