Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr 679 #689

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Test pr 679 #689

merged 1 commit into from
Dec 5, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (88f4614) 87.53% compared to head (4cb67ea) 88.77%.

❗ Current head 4cb67ea differs from pull request most recent head abdc005. Consider uploading reports for the commit abdc005 to get more accurate results

Files Patch % Lines
lib/agent/https_proxy_ocsp_agent.js 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   87.53%   88.77%   +1.24%     
==========================================
  Files          61       61              
  Lines        5791     5693      -98     
==========================================
- Hits         5069     5054      -15     
+ Misses        722      639      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review December 4, 2023 21:27
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner December 4, 2023 21:27
package.json Outdated Show resolved Hide resolved
Add env vars for proxy options

Upgrade https-proxy-agent - PR-679 - add protocol to connectionConfig proxy
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit efa44c7 into master Dec 5, 2023
44 of 46 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the test_pr_679 branch December 5, 2023 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants