Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several fixes and changes #298

Merged
merged 11 commits into from
May 3, 2023
Merged

Several fixes and changes #298

merged 11 commits into from
May 3, 2023

Conversation

jacobdotcosta
Copy link
Member

@jacobdotcosta jacobdotcosta commented Apr 20, 2023 •
edited
Loading

  • Improved script output to include include on:
    • the container registry
    • the htpasswd file
    • removal and installation steps
  • Added a switch to deploy a sample application based on the nginx container

Closes #288
Closes #300
Closes #301

@jacobdotcosta jacobdotcosta self-assigned this Apr 20, 2023
@jacobdotcosta jacobdotcosta changed the title Add registry info Several fixes and changes Apr 20, 2023
@jacobdotcosta
feat: added resume information for several operations
4dba2f7 
such as deploy the ingress and removal of the cluster and registry container
@jacobdotcosta jacobdotcosta marked this pull request as ready for review April 20, 2023 06:45
cmoulliard
cmoulliard requested changes Apr 20, 2023
View reviewed changes
kind/images.json Outdated Show resolved Hide resolved
cmoulliard
cmoulliard reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@cmoulliard cmoulliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see part of the http-server.yaml the resource to create the ingress route (if we keep the sample of course part of this bash script)

kind/kind.sh Outdated Show resolved Hide resolved
@jacobdotcosta jacobdotcosta requested a review from cmoulliard May 3, 2023 10:51
@jacobdotcosta
Copy link
Member Author

Closes #300

@jacobdotcosta
Copy link
Member Author

jacobdotcosta commented May 3, 2023 •
edited
Loading

Added an option to set the registry name.

  --registry-name <name>			Name of the registry. Default: <cluster_name>-registry

@cmoulliard would this fix #301 ?

@jacobdotcosta jacobdotcosta merged commit 33ccc3f into snowdrop:main May 3, 2023
@jacobdotcosta jacobdotcosta deleted the add-registry-info branch May 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmoulliard cmoulliard cmoulliard approved these changes

Assignees

@jacobdotcosta jacobdotcosta

Labels
module::kind
Projects
None yet
Milestone
No milestone
2 participants
@jacobdotcosta @cmoulliard