Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal: not a git repository (or any parent up to mount point /) #92

Closed
tocic opened this issue May 2, 2023 · 1 comment · Fixed by #93
Closed

fatal: not a git repository (or any parent up to mount point /) #92

tocic opened this issue May 2, 2023 · 1 comment · Fixed by #93
Labels
bug:confirmed Something isn't working (confirmed)
Milestone

Comments

@tocic
Copy link
Member

tocic commented May 2, 2023

When building the library using a tarball or a .zip archive there's no .git dir in the project root. And, consequently, you'll get the following message in the stderr:

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

from this command:

https://github.com/cschreib/snitch/blob/d040b89227a4cea74986aeaf4b57ec62994cab7e/CMakeLists.txt#L33-L38

That doesn't prevent the configuration, but the red message is still annoying.

The simplest solution is to add ERROR_QUIET to the command above. That will also fix the git: not found message in case you have a git-less environment (e.g., FROM alpine in docker), but may silence other errors if any.

I'm not familiar with meson, but perhaps this should be fixed too:

https://github.com/cschreib/snitch/blob/d040b89227a4cea74986aeaf4b57ec62994cab7e/snitch/meson.build#L4

@cschreib
Copy link
Member

cschreib commented May 2, 2023

Thanks, on it.

@cschreib cschreib added this to the v1.1 milestone May 26, 2023
@cschreib cschreib added the bug:confirmed Something isn't working (confirmed) label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working (confirmed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants