Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error response for non-compliant accounts? #1466

Closed
edent opened this issue Nov 11, 2024 · 6 comments
Closed

Better error response for non-compliant accounts? #1466

edent opened this issue Nov 11, 2024 · 6 comments
Labels
feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols.

Comments

@edent
Copy link
Contributor

edent commented Nov 11, 2024

I was unable to receive a follow from the AP-Bsky bridge.

When I finally read the documentation I saw that my account wasn't yet 2 weeks old. I fixed that, and it worked.

However, the response I received to my initial follow request was:

Added receive task projects/bridgy-federated/locations/us-central1/queues/receive/tasks/26081956632065569231
delay None
b'as2={"@context":"https://www.w3.org/ns/activitystreams","actor":"..."
&received_at=2024-11-11T08:43:46.403643+00:00&source_protocol=activitypub'

(Truncated for clarity)

Would it be possible / sensible to add an error message to that response explaining the problem?

@snarfed
Copy link
Owner

snarfed commented Nov 11, 2024

Hi Terence, good to see you here! Absolutely, this is a good idea. I think we're tracking this as #758, would that work for you?

@edent
Copy link
Contributor Author

edent commented Nov 11, 2024

@snarfed 👋

In my case, no. Because I haven't written the code to read DMs 🤣

But, in general, yes.

@Tamschi
Copy link
Collaborator

Tamschi commented Nov 11, 2024

I think this is distinct enough to track it separately.
(There's probably not much overlap in the eventual message compared to #758.)

@Tamschi Tamschi added the feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols. label Nov 11, 2024
@snarfed
Copy link
Owner

snarfed commented Nov 11, 2024

The catch is, the "error response" here is an internal log message that you only see if you click through from your user page on https://fed.brid.gy/ . Exposing logs publicly has been useful, but also confusing and flaky. I've added a few band-aids here and there, but making it actually reliable and useful would take distributed tracing across the backend infrastructure, which would be a big project that realistically I doubt I'd prioritize. If anything, I'd just remove the logs altogether.

Previously: #620, #541, etc

@edent
Copy link
Contributor Author

edent commented Nov 11, 2024

Fair enough. I can accept that I'm a niche 😄

@edent edent closed this as completed Nov 11, 2024
@Tamschi
Copy link
Collaborator

Tamschi commented Nov 11, 2024

I'll merge this into #758, in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols.
Projects
None yet
Development

No branches or pull requests

3 participants