Got panic on async connect

[jaudiger]

Hi,

Since the last release of the crate, I'm beggining to have a strange panic after trying to do an async connect with the following code:

    let header = Request::builder()
        .uri("ws://localhost:5683")
        .header(http::header::SEC_WEBSOCKET_PROTOCOL, "test")
        .body(())
        .unwrap(); // Safe
    let (mut websocket_client, _) = tokio_tungstenite::connect_async(header).await.unwrap();

I got:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Protocol(InvalidHeader("sec-websocket-key"))'

[sdroege]

You need to provide the sec-websocket-key and other headers yourself now if you create the request yourself.

Something like

        let req = Request::builder()
            .method("GET")
            .header("Host", host)
            .header("Connection", "Upgrade")
            .header("Upgrade", "websocket")
            .header("Sec-WebSocket-Version", "13")
            .header("Sec-WebSocket-Key", tungstenite::generate_key())
            .uri(self)
            .body(())?;

Or you go via your_uri.into_client_request() to get a default Request that you can then modify.

[daniel-abramov]

Ok, the question seems to be answered :)

Note it's the same issue as described here.

As for the rationale, you can read the reasoning behind the change here:

• client: overhaul of the request generation tungstenite-rs#259
• HeaderName::from_static requires all-lowercase HTTP2 compatible hea… tungstenite-rs#267 (comment)

[jaudiger]

Yep, thanks.