Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display voting and proposal validation settings on Space About page #3761

Open
samuveth opened this issue Apr 17, 2023 · 7 comments
Open

Display voting and proposal validation settings on Space About page #3761

samuveth opened this issue Apr 17, 2023 · 7 comments
Labels
design enhancement New feature or request

Comments

@samuveth
Copy link
Contributor

samuveth commented Apr 17, 2023

We need to enhance the visibility of proposal and voting validation settings by displaying them on the Space About page. There are two primary validation types, Basic and Gitcoin Gated, each with different information to display.

Required Information

Basic Validation:

  • Minimum Score (minScore)
  • Strategies

Gitcoin Gated Validation:

  • Stamps
  • Requirement (whether all or any single stamp is needed)

Before implementing the feature, let's first agree on a basic design that effectively showcases the required information for both validation types. Once we have reached a consensus on the design, we can work on the implementation.

@samuveth samuveth added enhancement New feature or request design labels Apr 17, 2023
@Todmy
Copy link
Contributor

Todmy commented May 30, 2023

Let's start with this draft

Image
Image

@samuveth
Copy link
Contributor Author

For Basic validation we should not show minScore on each strategy. The minscore is for all strategies combined. Also would be better to have one element like you did with Gitcoin Gated, where we list the strategies by name.

Like this:

Basic
Minimum score: 1
Strategies: erc20, erc712, ...

@Todmy
Copy link
Contributor

Todmy commented May 31, 2023

Image

@Todmy Todmy assigned Todmy and unassigned vnmtvlv May 31, 2023
@samuveth
Copy link
Contributor Author

We have proposal and vote validation. Are we going to have a separate block for each?

https://score.snapshot.org/api/validations

Also for proposal validation we have an extra validation arbitrum you can see in the link above it has a proposalValidationOnly property.

@samuveth
Copy link
Contributor Author

samuveth commented May 31, 2023

From the example for arbitrum I think we should show all these:

{
"minBps": 1,
"address": "0x912CE59144191C1204E64559FE8253a0e49E6548",
"decimals": 18,
"excludeaddr": "0x00000000000000000000000000000000000A4B86",
"strategies": []
}

@Todmy
Copy link
Contributor

Todmy commented Jun 1, 2023

Image
Image

@zzuziak
Copy link
Contributor

zzuziak commented Aug 2, 2023

FYI: More Validation strategies are coming. I guess it's difficult, but maybe we can think of a solution that will be flexible and possible to use for various implementations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants