-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from eth_sign to personal_sign for login #3453
Comments
Hi @snarflakes, which login are you referring to? We use EIP-712 TypedData for signing messages on snapshot, this includes improved readability already. |
It was the edit profile signature, but i can check the others too. I can screenshot it too if need be. Thanks |
i guess these are just two different signature/sign-in strategies... I'm still learning these signature formats. One seems more user friendly than the other. Sorry I guess these are dueling strategies. And then there is, https://eips.ethereum.org/EIPS/eip-4361 which seems to be incorporating more the EIP-191 signing strategies. |
Okay, I see what you mean and I agree this should definitely be improved on our side. I will create an issue for it. |
Briefly describe the feature.
using outdated account authentication signature with little info on signing
Which problem is this feature trying to solve?
Improve trust to new users.
What is the expected solution?
Switch signing from eth_sign to personal_sign type signature for improved readability.
How do you currently handle this problem?
just trust signature request at this point
Anything else you'd like to mention?
No response
The text was updated successfully, but these errors were encountered: