Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add limit param to data resources #64

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

BonySmoke
Copy link

The purpose of the PR is to add the limit param to certain data resources so that it's possible to either get all the records or only the needed number.
All the changes have been generated using the netbox_generate_json_datasources.sh script.

@auto-add-label auto-add-label bot added the enhancement New feature or request label Sep 17, 2021
@auto-assign auto-assign bot requested a review from smutel September 17, 2021 11:20
@smutel
Copy link
Owner

smutel commented Sep 18, 2021

I have some issue with the CI, I will get back to you.

@smutel
Copy link
Owner

smutel commented Sep 19, 2021

Namchee/conventional-pr#28

@smutel
Copy link
Owner

smutel commented Sep 19, 2021

Could you please replace in file .github/workflows/pr.yml:

uses: Namchee/[email protected]

by

uses: Namchee/conventional-pr@master

@BonySmoke
Copy link
Author

Could you please replace in file .github/workflows/pr.yml:

uses: Namchee/[email protected]

by

uses: Namchee/conventional-pr@master

Just in case - Done :)

Copy link
Owner

@smutel smutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smutel smutel merged commit 7bcff6d into smutel:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants