Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the wepoll dependency? #22

Closed
Plecra opened this issue Oct 16, 2020 · 3 comments · Fixed by #88
Closed

Removing the wepoll dependency? #22

Plecra opened this issue Oct 16, 2020 · 3 comments · Fixed by #88

Comments

@Plecra
Copy link

Plecra commented Oct 16, 2020

Would it be possible to implement the windows backend directly in rust? I think making the code as accessible as possible to users is especially important with a library like this (mostly for debugging).

It looks like mio is written with {nt, win}api, and maybe it could be used as reference here.

@ghost
Copy link

ghost commented Oct 18, 2020

It would require a lot of effort and would likely introduce bugs in the beginning. The wepoll implementation in C is really high quality so I find little reason to port the code to Rust. It's true that porting would make compiling polling on windows a bit smoother though!

Anyways... I don't have the time to do this right now :( If somebody else wants to give this a shot, that would be very much appreciated!

@yorickpeterse
Copy link
Contributor

mio ended up adopting the wepoll approach, but IIRC their code is written from scratch. Last I checked, there were still a bunch of issues with their implementation. This is why I avoid mio myself: its Windows support seems questionable at best. wepoll on the other hand is solid as a rock, and compiling it is quite easy/fast.

@notgull
Copy link
Member

notgull commented Aug 22, 2022

wepoll is fine for now. If we want to further integrate files into our event loop we'll probably either need to patch wepoll or come up with our own solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants