Add more -hints to the simulator

[scheibo]

PS generally needs more hints.

Originally posted by @Zarel in #5226

This bug will track improving our -hint coverage. As a rule, I think there should be hints for unintuitive/glitchy mechanics that occur infrequently or are a common source of misfiled bugs. Infrequently is key - mechanics that are showing up every game in a generation are probably not -hint-worthy. Another important requirement on top of not being spammy is that a -hint must not leak information.

I'm going to go by generation and see where -hints, what already has -hints, and behavior which is glitchy but which we likely do not want -hints for. I don't know if all of these glitches are even implemented correctly in PS currently, but in the process of adding hints for them I'm surely we'll find out ;)

Gen I

Unintuitive/bugged behavior that should probably have -hints:

• Toxic counter glitch (Leech Seed / Rest)
• 1/256 miss glitch
• Struggle bypassing glitch (ie. Wrap PP underflow)
• Substitute + confusion / (Hi) Jump Kick glitch
• Substitute + Explosion / Self-destruct glitch
• Hyper Beam + Sleep move glitch
• Haze thawing Pokemon frozen during Hyper Beam recharge
• HP recovery move failure (255 / 511) glitch

Other incongruencies we might possibly consider adding -hints for:

• Substitute not blocking status
• Counter mechanics
• Bide mechanics

Mechanics which seem too fundamental/common to explain with -hint:

• Hyper Beam skipping recharge glitch
• Crit Rate
• Borked type chart (Bug, Poison, Ghost)
• Status + modify stat reapplication glitch

Sources: Bulbapedia: Glitches I, Smogon: Important RBY Differences

Gen II

Unintuitive/bugged behavior that should probably have -hints:

• Draining moves missing against Substitute
• Belly drum when below half HP
• Pursuit faint + switch continuing
• Toxic counter glitches (Baton Pass / Heal Bell)
• 1024 rollover (Thick Club / Light Ball, Reflect / Light Screen, Metal powder increasing damage)
• 1/256 miss for 100% secondary effects
• Present mechanics

Other incongruencies we might possibly consider adding -hints for:

• Lock On / Mind Reader + Fly / Dig
• Confusion damage + items/Explosion
• Defense being lowered as a secondary effect after Substitute is broken
• Beat Up mechanics (King's Rock / Substitute / 1 Pokemon left)

Sources: Bulbapedia: Glitches II, pokecrystal: Bugs and Glitches

Gen III

Unintuitive/bugged behavior that should probably have -hints:

• Pursuit faint + switch continuing
• Nightmare + Shed Skin behavior (Ruby / Sapphire only?)

Sources: Bulbapedia: Glitches III

Gen IV

Unintuitive/bugged behavior that should probably have -hints:

• Pursuit faint + switch continuing
• U-turn + Substitute + Intimidate
• Fire Fang hits through Wonder Guard

Sources: Bulbapedia: Glitches IV

Gen V / VI / VII

Unintuitive/bugged behavior that should probably have -hints:

• Locked move (non struggle) + no PP

Other incongruencies we might possibly consider adding -hints for:

• Type-changing Curse glitch (Doubles / Triples = Gen VI, Protean = Gen VI/VII)
• Choice item lock glitch
• Confusion damage + pinch item activation interplay

Sources: Bulbapedia: Glitches V VI VII

Common 'Not Bugs'

• Species specific moves (Dark Void + Darkrai, Hyperspace Fury + Hoopa Unbound)
• Fake Out / First Impression / Mat Block + first turn out
• Dark Types + Prankster

Possibly more that could be added without leaking information based on the thread.

Sources: Smogon - Pokemon Showdown Bug Reports

---

I don't think adding these hints are high priority, so I'm going to let this bug sit for now and hopefully some discussion comes out of it (should we have hints for these? are all these glitches accurate/valid for PS's implementation of each generation? maybe there are additional hints we could be adding?).

[scheibo]

From simply poking around the code, its not clear to me where some of these are implemented, if at all (in which case it maybe should be added to #2367)? Gen II Beat Up mechanics are already a known issue, but not sure about the following:

• Gen I: Haze thawing Pokemon frozen during Hyper Beam recharge resulting in the thawed Pokemon never being able to move again
• Gen II: Lock On / Mind Reader + Fly / Dig interaction with moves like Transform, Spider Web, etc
• Gen II: Confusion damage is affected by type-boosting items and Explosion/Self-Destruct doubling
  • I would expect this maybe here?
• Moves that lower Defense can do so after breaking a Substitute
  • I would expect this maybe here?

@Marty-D @DaWoblefet

[Marty-D]

Yeah, none of those are implemented yet except the type-boosting item part of Gen 2 confusion damage, which is where you expected it to be. I'll try to clean up Known Mechanics Bugs this weekend.

[scheibo]

Cools, copied that over there so I can close this out. I'll probably look into implementing them, but I don't want to commit that that right now :)