Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Parental Bond #330

Closed
scheibo opened this issue Aug 4, 2019 · 2 comments
Closed

Fix Parental Bond #330

scheibo opened this issue Aug 4, 2019 · 2 comments
Assignees

Comments

@scheibo
Copy link
Contributor

scheibo commented Aug 4, 2019

Parental Bond should run two independent strikes to calculate damage, not do a trivial damage = damage * modifier. Parental Bond causes the move to run an entirely new damage calculation and applies the baby hit modifier in between the spread move modifier and the weather modifier. As a result, there should be two independent sets of damage rolls displayed, as well as percent to KO being based on 256 combinations of damage rolls, not 16. Displaying it as a combination would require displaying potentially 256 damage rolls, so most damage calculators that implement Parental Bond accurately do something like this:

Originally posted by @DaWoblefet on Smogon

This will likely require making calc.calculate return a Result[] instead of Result, or something to that effect. The VGC calc handles this already, might be worth looking to see what they're doing.

@scheibo scheibo self-assigned this Aug 4, 2019
@scheibo
Copy link
Contributor Author

scheibo commented Aug 4, 2019

This is somewhat obnoxious with our existing multi hit support. Also, TT just returns parentDamage and childDamage instead damage (but one description). Not sure if we want that or Result, will need to think about it.

@scheibo
Copy link
Contributor Author

scheibo commented Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant