Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service renames after flattenNamespaces #2109

Commits on Jan 23, 2024

  1. Remove service renames after flattenNamespaces

    flattenNamespaces applies all service renames to disambiguate shapes
    that could be in conflict after flattening. But when consumers try to
    reload the transformed model, they get an error like:
    ```
    "Service rename for `foo` does not actually change the name from `bar`"
    ```
    because the rename has already been applied. This commit changes
    FlattenTransformer to also update the service shape by removing all renames,
    so consumers of a flattened model don't run into validation issues.
    milesziemer committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    47ca575 View commit details
    Browse the repository at this point in the history