Add back vendorParamsShape if removed by transformers #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a ModelTransformerPlugin to smithy-smoke-test-traits that will add back shapes referenced by a smoke test case vendorParamsShape that were removed by model transforms. Transforms like removeUnusedShapes will remove these shapes since they aren't connected to the model graph as @idref's don't create edges. To accomplish this, ModelTransformerPlugin was given an `order` used to sort the plugins. This was required to make the new plugin run after all other plugins, which may remove more shapes that need to be added back.
|
Closing in favor of #2105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ModelTransformerPlugin to smithy-smoke-test-traits that will add back shapes referenced by a smoke test case vendorParamsShape that were removed by model transforms. Transforms like removeUnusedShapes will remove these shapes since they aren't connected to the model graph as @idref's don't create edges.
To accomplish this, ModelTransformerPlugin was given an
orderused to sort the plugins. This was required to make the new plugin run after all other plugins, which may remove more shapes that need to be added back.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.