Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale docs around MissingPaginatedTrait #1814

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

rchache
Copy link
Contributor

@rchache rchache commented Jun 8, 2023

Issue #, if available:
#1764 (comment)

Description of changes:
Updated the 2.0 docs to reflect the newest default list of member names that indicate pagination is needed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchache rchache requested a review from a team as a code owner June 8, 2023 21:15
Copy link
Member

@mtdowling mtdowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this render correctly and without a newline in the literal?

@rchache
Copy link
Contributor Author

rchache commented Jun 8, 2023

Renders as

Defines the case-insensitive operation input member names that indicate that an operation MUST be paginated. A DANGER event is emitted if an operation is found to have an input member name that case-insensitively matches one of these member names. Defaults to ["maxresults", "maxitems", "pagesize", "limit", "nexttoken", "pagetoken", "token", "marker"]

Defines the case-insensitive operation output member names that indicate that an operation MUST be paginated. A DANGER event is emitted if an operation is found to have an output member name that case-insensitively matches one of these member names. Defaults to ["nexttoken", "pagetoken", "token", "marker", "nextpage", "nextpagetoken", "position", "nextmarker", "paginationtoken", "nextpagemarker"].

image

@mtdowling mtdowling merged commit 32b70c7 into smithy-lang:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants