Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing protocol test for xmlnamespace-trait applied on service shape #616

Closed
skotambkar opened this issue Oct 28, 2020 · 0 comments
Closed

Missing protocol test for xmlnamespace-trait applied on service shape #616

skotambkar opened this issue Oct 28, 2020 · 0 comments

Comments

@skotambkar
Copy link
Contributor

XmlNamespace trait can be applied on service shapes. We should have protocol tests around this behavior.

Found this issue as Route53 depend on this trait to correctly serialize xmlns into the request body.
Related to aws/aws-sdk-go-v2#850 .
@mtdowling mtdowling mentioned this issue Nov 28, 2020
Merged
mtdowling added a commit that referenced this issue Nov 28, 2020
@mtdowling
Clarify various aspects of xmlNamespace traits
930ac23 
* The xmlNamespace trait can only be applied to simple types, list,
  map, set, structure, union, member, and service shapes. We previously
  allowed "*", but that includes resource and operation shapes where
  the trait isn't actually used.
* aws.protocols#awsQuery and aws.protocols#ec2Query protocol traits
  both now require that an xmlNamespace is set on the top-level
  service shape they are applied to so that the namespace is
  guaranteed to be known.
* Added various examples for how the xmlNamespace trait interacts
  with flattened lists and maps.
* Add a protocol test suite named "restXmlWithNamespace" to test that
  implementations add an xmlns to restXml services when necessary,
  closing #616
mtdowling added a commit that referenced this issue Dec 1, 2020
@mtdowling
Clarify various aspects of xmlNamespace traits
3482e88 
* The xmlNamespace trait can only be applied to simple types, list,
  map, set, structure, union, member, and service shapes. We previously
  allowed "*", but that includes resource and operation shapes where
  the trait isn't actually used.
* aws.protocols#awsQuery and aws.protocols#ec2Query protocol traits
  both now require that an xmlNamespace is set on the top-level
  service shape they are applied to so that the namespace is
  guaranteed to be known.
* Added various examples for how the xmlNamespace trait interacts
  with flattened lists and maps.
* Add a protocol test suite named "restXmlWithNamespace" to test that
  implementations add an xmlns to restXml services when necessary,
  closing #616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtdowling @skotambkar