Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smithy format puts postfix inline comments in the wrong place #2431

Closed
rhernandez35 opened this issue Oct 24, 2024 · 2 comments
Closed

smithy format puts postfix inline comments in the wrong place #2431

rhernandez35 opened this issue Oct 24, 2024 · 2 comments
Labels
bug This issue is a bug.

Comments

@rhernandez35
Copy link
Contributor

smithy format will turn this:

operation Demo {
    input: Unit // No input
    output := {
        foo: String
    }
}

into this:

operation Demo {
    input: Unit

    // No input
    output := {
        foo: String
    }
}

I would expect a trailing comment to adorn the syntactical element it's sharing a line with and not with the element following it.

@tripplilley
Copy link

Possible duplicate of #2279

@milesziemer milesziemer added the bug This issue is a bug. label Nov 1, 2024
@kstich
Copy link
Contributor

kstich commented Nov 5, 2024

Correct, closing as a duplicate of #2279

@kstich kstich closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

4 participants