Do not trim collection query param output values #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, server request deserializers would trim leading and trailing whitespace of output query parameter values. This PR stops that, so the whitespace is preserved as part of the query value.
kuhe
approved these changes
May 12, 2023
srchase
approved these changes
May 17, 2023
milesziemer
added a commit
to milesziemer/aws-sdk-js-v3
that referenced
this pull request
May 18, 2023
This is the codegen PR for smithy-lang/smithy-typescript#764.
milesziemer
added a commit
to milesziemer/aws-sdk-js-v3
that referenced
this pull request
May 18, 2023
This is the codegen PR for smithy-lang/smithy-typescript#764.
trivikr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously, server request deserializers would trim leading and trailing whitespace of output query parameter values. This PR stops that, so the whitespace is preserved as part of the query value.
Tested using JS SDK. All protocol tests continue to pass, there is a codegen diff.
This PR is required for smithy-lang/smithy#1759
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.