You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes error handling more difficult, as the caller does not know which AbortSignal e.g. when used with AbortSignal.any caused the request to be aborted.
I recommend changing the code to reject with AbortSignal.reason when an AbortSignal is aborted (at least for native AbortSignal implementations).
The text was updated successfully, but these errors were encountered:
u873838
changed the title
Aborted requests should be rejected with with AbortSignal.reason
Aborted requests should be rejected with AbortSignal.reason
Aug 1, 2024
The current behavior of aborted request cause the promise to reject with a simple
Error
. e.g.:smithy-typescript/packages/node-http-handler/src/node-http-handler.ts
Lines 171 to 173 in efcbbf4
smithy-typescript/packages/node-http-handler/src/node-http-handler.ts
Lines 249 to 251 in efcbbf4
This makes error handling more difficult, as the caller does not know which AbortSignal e.g. when used with
AbortSignal.any
caused the request to be aborted.I recommend changing the code to reject with
AbortSignal.reason
when an AbortSignal is aborted (at least for nativeAbortSignal
implementations).The text was updated successfully, but these errors were encountered: