Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic API for modifying headers #605

Closed
rcoh opened this issue Jul 26, 2021 · 7 comments
Closed

generic API for modifying headers #605

rcoh opened this issue Jul 26, 2021 · 7 comments

Comments

@rcoh
Copy link
Collaborator

rcoh commented Jul 26, 2021

see #583

There should be a generic way to add headers to request

@rcoh rcoh added the enhancement New feature or request label Jul 26, 2021
@rcoh
Copy link
Collaborator Author

rcoh commented Jul 26, 2021

key-val support for adding to the user agent

@marcbowes
Copy link
Contributor

We (qldb) are just about ready to ship our 2.0 shell based on the awssdk for Rust. At this point, setting the user agent is the only blocking issue in terms of feature parity. If you give us some pointers, we can probably contribute this.

@rcoh
Copy link
Collaborator Author

rcoh commented Oct 6, 2021

Because you’re already using the low level API, you can actually do this directly with no code changes on the SDK side, just use properties_mut() on the operation to set a custom AwsUserAgent

@rcoh
Copy link
Collaborator Author

rcoh commented Oct 6, 2021

we may need some very small changes depending on exactly what you want the user agent to be, but those should be quite minor and isolated

@rcoh
Copy link
Collaborator Author

rcoh commented Dec 13, 2021

@rcoh rcoh added this to the GA milestone Dec 13, 2021
@jdisanti
Copy link
Collaborator

RFC for this feature

@jdisanti
Copy link
Collaborator

Resolving this in favor of #1112. Looks like it got duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants