-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maps/lists with sensitive members not redacted #3765
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a lot of changes that actually seem to relax debug/display implementations. Have you verified this is the desired/correct behavior change? Were we over redacting before?
Good catch! That was a bug (same one causing the CI failures) and should be fixed in 4b398c7 |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Great work! Probably this warrants a |
A new generated diff is ready to view.
A new doc preview is ready to view. |
This needs to be ported over to It also looks like we never added |
Motivation and Context
Lists and maps with sensitive members were not being properly redacted. Closes #3757
Description
Updated
Shape.shouldRedact
method to properly check for list and map shapes with sensitive members. Also updated the test definition so it would actually run since previously the test code was generated in a nested function inside a no-op function and never run.Testing
Added test cases for lists with sensitive members, maps with sensitive keys, and maps with sensitive values.
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.