Move Message, Header, HeaderValue, and StrBytes from aws-smithy-eventstream to aws-smithy-types
#3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
added
breaking-change
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
commented
Nov 2, 2023
...lin/software/amazon/smithy/rust/codegen/core/smithy/customizations/SmithyTypesPubUseExtra.kt
Show resolved
Hide resolved
jdisanti
reviewed
Nov 2, 2023
...lin/software/amazon/smithy/rust/codegen/core/smithy/customizations/SmithyTypesPubUseExtra.kt
Show resolved
Hide resolved
...lin/software/amazon/smithy/rust/codegen/core/smithy/customizations/SmithyTypesPubUseExtra.kt
Show resolved
Hide resolved
rust-runtime/aws-smithy-eventstream/fuzz/fuzz_targets/round_trip.rs
Outdated
Show resolved
Hide resolved
drganjoo
approved these changes
Nov 2, 2023
| pub(crate) const TYPE_STRING: u8 = 7; | ||
| pub(crate) const TYPE_TIMESTAMP: u8 = 8; | ||
| pub(crate) const TYPE_UUID: u8 = 9; | ||
|
|
There was a problem hiding this comment.
Just a general question, so we do not allow a float / double as a type in HeaderValue? I guess, they can always be passed as a String.
...lin/software/amazon/smithy/rust/codegen/core/smithy/customizations/SmithyTypesPubUseExtra.kt
Show resolved
Hide resolved
This commit addresses #3139 (comment) #3139 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes the following statement in #3114
so that the
recvmethod on a new-type wrapperaws_smithy_http::event_stream::Receivercan exposeSdkError<E, RawMessage>>in public API. It is the responsibility of the above PR to move RawMessage fromaws-smithy-httptoaws-smithy-typesbut doing so first requiresMessageto be moved toaws-smithy-types, hence this PR.Description
Moving
Messagetoaws-smithy-typesalso requires moving the types it depends upon, namelyHeader,HederValue, andStrBytes. However, their serialization/deserialization methods (read_fromandwrite_to) remain inaws-smithy-eventstreamand they are converted to free functions, with the aim of moving things as minimally as possible.aws-smithy-eventstreamhas fuzz testing. It previously implemented theArbitrarytrait for moved types, but since they are now inaws-smithy-types, we need to have newtypes for them to enable the trait due to the orphan rules. A newly added moduleaws-smithy-eventstream::arbitraryis exactly for that purpose.Testing
Relied on the existing tests.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.