Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate an inlined new-type struct with an async .send() method for aws_smithy_http::event_stream::receiver::Sender #3118

Open
ysaito1001 opened this issue Oct 31, 2023 · 0 comments
Labels
event-stream refactoring Changes that do not affect our users, mostly focused on maintainability

Comments

@ysaito1001
Copy link
Contributor

Context: #3114 (comment)

Just as we generated an inlined new-type with an async recv() method for aws_smithy_http::event_stream::receiver::Receiver, the Sender can also benefit from having a similar new-type.

There is a question of what to new-type from the aws_smithy_http::event_stream::sender because there are two structs Sender and MessageStreamAdapter. Given that the former is merely used to create the later, it probably makes sense to new-type the latter, but that needs to be double-checked.

Since we currently do not expose Sender (or MessageStreamAdapter) in public API within stable crates, this work can be done with a backwards compatible manner.

@jdisanti jdisanti added refactoring Changes that do not affect our users, mostly focused on maintainability event-stream labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-stream refactoring Changes that do not affect our users, mostly focused on maintainability
Projects
None yet
Development

No branches or pull requests

2 participants